anthonyfieroni added inline comments. INLINE COMMENTS
> soliddeviceengine.cpp:67 > + KDiskFreeSpaceInfo info = KDiskFreeSpaceInfo::freeSpaceInfo(m_path); > + emit infoObtained(m_path, m_udi, info.isValid(), info.available(), > info.size()); > +} Don't you forget to emit finished? > soliddeviceengine.cpp:591-600 > + connect(thread, SIGNAL(started()), worker, SLOT(getFreeSpaceInfo())); > + connect(worker, SIGNAL(finished()), thread, SLOT(quit())); > + > + // delete later thread and worker > + connect(worker, SIGNAL(finished()), worker, SLOT(deleteLater())); > + connect(thread, SIGNAL(finished()), thread, SLOT(deleteLater())); > + Use new connect syntax . > soliddeviceengine.cpp:622 > + > + m_timers[path]->deleteLater(); > + m_timers.remove(path); It does not need, you connect finished to deleteLater. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
