anthonyfieroni added inline comments. INLINE COMMENTS
> soliddeviceengine.cpp:564 > + > + m_timers[path] = timer; > + You can remove it, see below. > soliddeviceengine.cpp:574 > + connect(job, &KIO::FileSystemFreeSpaceJob::result, > + [this, path, udi](KIO::Job *job, KIO::filesize_t size, > KIO::filesize_t available) { > + if (m_timers[path]->isActive()) Capture timer too > soliddeviceengine.cpp:575-576 > + [this, path, udi](KIO::Job *job, KIO::filesize_t size, > KIO::filesize_t available) { > + if (m_timers[path]->isActive()) > + m_timers[path]->stop(); > + You can omit declaration of map, just timer->stop(); REVISION DETAIL https://phabricator.kde.org/D14895 To: McPain, broulik, ngraham, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart