davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > davidedmundson wrote in desktop.cpp:46 > In the other patch VirtualDesktopInfo has a shared d ptr across all instances. > > There's no point making VirtualDesktopInfo shared when it internally does it > itself anyway. You save practically nothing. This comment wasn't addressed. It goes for the other containment actions patch too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15599 To: hein, mart, davidedmundson Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
