hein updated this revision to Diff 43810. hein added a comment.
- Fix another arg() call - Do delete+remove in one step with take() - Fix loop condition Addressing other review comments: - More change tracking is not needed because of the later loop that indiscriminately calls setText/setData on all actions - The suggested qDeleteAll+resize method doesn't work because QHash has no resize() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43754&id=43810 BRANCH arcpatch-D15599 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED FILES containmentactions/switchdesktop/CMakeLists.txt containmentactions/switchdesktop/desktop.cpp containmentactions/switchdesktop/desktop.h containmentactions/switchwindow/switch.cpp To: hein, mart, davidedmundson Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
