Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  This also fixes the `Background { id: backgroundButtons }` not hiding by 
binding it's visibility to `buttons.visible`.
  
  Is the "bugfix" worth splitting into it's own commit and backporting to 5.15, 
while the new feature goes into master/5.16?

TEST PLAN
  - Patch 
`/usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/views/`
  - Compile and run `build/bin/plasmoidviewer -a org.plasma.digitalclock 
--nobuttons`
  - Run `build/bin/plasmoidviewer -a org.plasma.digitalclock` and confirm the 
"hide" button still works.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D19233

AFFECTED FILES
  plasmoidviewer/main.cpp
  plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml
  plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
  plasmoidviewer/view.cpp
  plasmoidviewer/view.h

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to