broulik added inline comments.
INLINE COMMENTS
> powerdevilcore.cpp:541
> msg = i18nc("Placeholder is device name",
> - "The battery in your mouse (\"%1\") is low, and
> the device may turn itself off at any time. "
> - "Please replace or charge the battery as soon as
> possible.", name);
> + "The battery in (\"%1\") is running low, and the
> device may turn off at any time. "
> + "Please recharge or replace the battery.", name);
Since you removed the separation between the three cases you might as well
unify the codebase into one. Now you have three separate identical strings.
Also, "The battery in (some device) is running low" with the parenthesis is a
bit awkward since now it's the sentence's subject.
> powerdevilcore.cpp:580
> emitRichNotification(QStringLiteral("lowbattery"), i18n("Battery Low
> (%1% Remaining)", currentPercent),
> - i18n("Your battery is low. If you need to
> continue using your computer, either plug in your computer, or shut it down
> and then change the battery."));
> + i18n("Battery running low - to continue using
> your computer, plug it in or shut it down and change the battery."));
> return true;
not a fan of that hyphen. It is in the heading, so just change the main text to
"To continue using your computer..."
> powerdevilcore.cpp:641
> i18n("AC Adapter Plugged In"),
> - i18n("All pending suspend actions have been
> canceled."));
> + i18n("The computer will no longer go to
> sleep."));
> } else {
Sounds like from now on it will never suspend anymore.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D19838
To: rooty, #vdg, #plasma, broulik, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
