hein added inline comments.

INLINE COMMENTS

> apol wrote in ItemGridDelegate.qml:33
> so model.enabled you want it to resolve to true? This will be hard to read to 
> anyone who isn't you.
> 
> How about `model.hasOwnProperty("enabled") && model.enabled`? Or `typeof 
> model.enabled === "undefined" || model.enabled`

For the record (so someone doesn't copy this idea), model.hasOwnProperty() 
wouldn't work to catch unimplemented roles in a model.

I'll do another approach you might like better.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20237

To: hein, #plasma, davidedmundson
Cc: broulik, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to