ratijastk added a comment.

  So, I've merged done git rebase on master — just one conflicting line, 
rewritten after me in a better way.  But now I have no way to test it, because 
CMake Error `Could not find a configuration file for package "ECM" that is 
compatible with requested version "5.58.0"` and even all-up-to-date Arch Linux 
does not provide those pieces. I've installed the latest CMake from the 
`testing` repository, but other versioning issues showed up.
  
  I'm not a big fan of submitting without checking, but I don't see any other 
way around.

INLINE COMMENTS

> davidedmundson wrote in CompactApplet.qml:34
> When you say it did nothing, You'd need to test every hidden applet whilst 
> having the panel on the left.
> 
> See D1253 <https://phabricator.kde.org/D1253>
> 
> If it ain't broke...

As far as I remember, one of the branches never got executed in my environment. 
Could you point to specific use case which requires this "almost dead" code?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to