broulik added a comment.

  The padding on the left of the `TextField` looks off and what's up with that 
clear button?
  F7118082: Screenshot_20190730_084115.png 
<https://phabricator.kde.org/F7118082>
  No tooltip shows up for the configure and close buttons.

INLINE COMMENTS

> RunCommand.qml:56
>          Layout.alignment: Qt.AlignTop
> +        height: queryField.implicitHeight
> +

Why?

> RunCommand.qml:59
>          PlasmaComponents.ToolButton {
> -            iconSource: "configure"
> +            implicitHeight: queryField.implicitHeight
> +            implicitWidth: queryField.implicitHeight

Why?

> RunCommand.qml:226
>              keyNavigationWraps: true
> -            highlight: PlasmaComponents.Highlight {}
>              highlightMoveDuration: 0

Why remove this? It breaks highlighting of history items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to