Please move this to the pmc mailing list.
From: Aleksandar Kurtakov <akurt...@redhat.com> To: "Eclipse platform general developers list." <platform-dev@eclipse.org> Date: 21.02.2019 17:27 Subject: Re: [platform-dev] SWT-GTK theme support Sent by: platform-dev-boun...@eclipse.org On Thu, Feb 21, 2019 at 5:59 PM Eric Williams <ericw...@redhat.com> wrote: Hello, I'd like to propose an addition to the SWT planning documents, specifically the target environments section wrt. to GTK3. Some background information: On the Linux side of things we often encounter users running custom GTK themes (i.e. themes not shipped with GTK itself) reporting issues against SWT. These issues are not actual bugs in SWT but simply issues with the user's theme. SWT exposes bugs in GTK themes quite often because we support widgets of all sizes, meaning themes that use padding/margin in odd places will usually see visual glitches (as an example). Native GTK applications usually don't expose such issues because they do not allow users to resize widgets below the GTK minimum size, which is a nice luxury we cannot offer due to API contracts. For years the position has been that SWT-GTK will support the default themes shipped with GTK itself. We *do* patch theme issues that SWT exposes against the default themes, but they are pretty rare as the default GTK themes are well supported. Now, some users are very attached to their custom themes and would prefer to maintain their own theme at their own cost. We have given users the option to do so via an environment variable that allows for injection of custom GTK CSS into SWT. Our only caveat here is that users who choose to go down this road are on their own -- SWT developers will not be fixing bugs in a user's custom GTK theme. This is a problem unique to Linux due to the nature of theming in GTK. Mac and Windows don't really have to deal with this, as by-and-large they do not support themes other than the default. My proposal: We should add some comment in the platform plan target environments section about GTK themes, namely: that we only support the default GTK themes shipped with GTK (not a desktop environment), and that users are more than welcome to use their own custom GTK theme at their own risk. I will also be happy to link to a wiki article (which I'll write very soon) which explains all of this in detail and what avenues are available to users who want to use custom GTK themes. The reason I bring this up is that there is often quite a bit of back and forth in Bugzilla about such topics, and having the position explained in a planning document will save SWT developers quite some time when this topic arises. In the project plan we currently have: "With respect to GTK+ 3 versions: the guaranteed version of GTK+ 3 which Eclipse SDK 4.11 will run on is 3.20 or newer. Eclipse SDK 4.11 will run on older GTK+ 3 versions no older than 3.10.0, however we cannot flag these as reference versions without significant community support for testing and/or development of fixes. Bugs only reproducible on GTK+ 3 versions older than 3.20 will be given a lower priority (or may not be fixed at all), compared to bugs which are reproducible on the target environments listed above." I propose adding: " With respect to GTK 3 versions: the guaranteed to work theme is Adwaita. Eclipse SDK will run with other GTK themes, however we cannot flag these as reference versions without significant community support for testing and/or development of fixes. Bugs only reproducible with themes other than Adwaita will be given a lower priority (or may not be fixed at all), compared to bugs which are reproducible on the target environments listed above." Whoever disagrees with the statement above should really come up with resources to handle the incoming bugs. Note that this is not any change just stating publicly the way things have been for the last few years at least. Thoughts? -- Eric Williams Software Engineer - Eclipse/SWT Team Red Hat _______________________________________________ platform-dev mailing list platform-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev -- Alexander Kurtakov Red Hat Eclipse Team_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__www.eclipse.org_mailman_listinfo_platform-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JGUKq1BgSpAO_RDZ0GAL80JS4YvZUV3RewTBoRXcums&s=j4mN2FWGJgIoRWnTxrFSHjtgwXACZr5nUj4kkxsz-Ds&e=
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev