On Thu, Oct 09, 2008 at 08:44:34AM -0700, Alan Irwin wrote:
> On 2008-10-09 16:42+0200 Werner Smekal wrote:
> 
> > Hi,
> >
> > sorry, that I (again) kick in late in this discussion, but this change was 
> > not the right solution. Actually, the macros PLDLLEXPORT/PLDLLIMPORT are 
> > not 
> > to be used outside pldll.h. Only PLDLLIMPEXP should be used in headers and 
> > source. This was correctly done for the plplot core source, but not for the 
> > driver sources. So I changed now all PLDLLEXPORT macros to PLDLLIMPEXP and 
> > ask anybody if he needs to use this macros only to use PLDLLIMPEXP or 
> > NNDLLIMPEXP ...
> >
> > Will commit that soon.
> 
> Thanks, Werner, for looking deeper into this issue and solving the problem
> at a more fundamental level.

This may not be quite the right long term solution. Language bindings
for example might be importing some symbols from the core library and
exporting others to the user. Similarly for drivers. 

I'm not quite sure why things work at the moment. I suspect it is
because the import is optional. We should probably try to fix this
though to make it really clear whether we are importing or exporting. 

I did this for the drivers - they use PLDLLEXPORT in the source because 
they only every export symbols to the core library. The imports are
defined elsewhere. 

Andrew

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to