On Thu, Oct 09, 2008 at 03:17:40PM -0700, Alan Irwin wrote: > On 2008-10-09 20:39+0100 Andrew Ross wrote: > > > It's not quite a cmake issue since we need xxxMAKINGDLL for the driver > > source file and xxxUSINGDLL for the core header files included by the > > source file. At the moment these are mutually exclusive so we can't do > > it with just cmake options. It will require some source code changes > > as well, or a change to the way we use the defines. So far as I can see > > we only need DLLEXPIMP for the header files which are used both for > > making the library and using it. > > Andrew, could you please explain further? I thought the whole point of > DLLEXPIMP was to mean one thing if xxxMAKINGDLL was set by CMake (e.g., in > src/CMakeLists.txt to build libplplot), and another if xxxUSINGDLL was set > by CMake, e.g., in drivers/CMakeLists.txt when building dynamic devices. So > I thought all was well for the dynamic drivers case as changed recently by > Werner. It appears from your comment that you have spotted some flaw in > that approach. What am I missing? Or are you happy with the current > dynamic devices build and thinking about some other build issue?
It is. Setting xxxUSINGDLL for the drivers ensures that all the symbols from the core library defined in plplot.h etc are imported into the driver. This is ok. However, there are some symbols in the driver files which are exported to the core library (mostly the dispatch_init function and DEVICE INFO structure. I think these would need xxxMAKINGDLL defined. Or am I missing something here? Andrew ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
