Hi,

The attached patches fix some compiler warnings:
plargs-patch Make sure the functions return a value.
cairo-patch Properly place parentheses, avoiding code having no effect.

I also noticed with gcc -Wall there are a lot of unused variables in plplot, if wanted I could provide a patch which removes those variables.

Regards,
Mark de Wever
Index: src/plargs.c
===================================================================
--- src/plargs.c        (revision 10343)
+++ src/plargs.c        (working copy)
@@ -2259,6 +2259,7 @@
 opt_cmap0(const char *opt, const char *optarg, void *client_data)
 {
   plspal0(optarg);
+  return 0;
 }
 
 /*--------------------------------------------------------------------------*\
@@ -2271,4 +2272,5 @@
 opt_cmap1(const char *opt, const char *optarg, void *client_data)
 {
   plspal1(optarg, TRUE);
+  return 0;
 }
Index: drivers/cairo.c
===================================================================
--- drivers/cairo.c     (revision 10343)
+++ drivers/cairo.c     (working copy)
@@ -540,7 +540,7 @@
        strncat(aStream->pangoMarkupString, "&", 
MAX_MARKUP_LEN-1-strlen(aStream->pangoMarkupString));
        break;
       case 60:
-       strncat(aStream->pangoMarkupString, "<", 
MAX_MARKUP_LEN)-1-strlen(aStream->pangoMarkupString);
+       strncat(aStream->pangoMarkupString, "<", 
MAX_MARKUP_LEN-1-strlen(aStream->pangoMarkupString));
        break;
       case 62:
        strncat(aStream->pangoMarkupString, ">", 
MAX_MARKUP_LEN-1-strlen(aStream->pangoMarkupString));
@@ -831,7 +831,7 @@
            strncat(pangoMarkupString, "&", 
MAX_MARKUP_LEN-1-strlen(pangoMarkupString));
            break;
          case 60:
-           strncat(pangoMarkupString, "<", 
MAX_MARKUP_LEN)-1-strlen(pangoMarkupString);
+           strncat(pangoMarkupString, "<", 
MAX_MARKUP_LEN-1-strlen(pangoMarkupString));
            break;
          case 62:
            strncat(pangoMarkupString, ">", 
MAX_MARKUP_LEN-1-strlen(pangoMarkupString));
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to