Alan W. Irwin wrote: > On 2009-08-26 11:12+0200 Mark de Wever wrote: >> The attached patches fix some compiler warnings: >> plargs-patch Make sure the functions return a value. >> cairo-patch Properly place parentheses, avoiding code having no effect. > > Thanks, Mark. I committed your plargs-patch and Hazen committed your > cairo-patch. Good spotting on that last one! I double-checked the many > other strncat calls within cairo.c, and it appears you found all the bad > ones.
Thanks for applying them. Spotting them was easy, I just had to enable gcc -Wall. >> I also noticed with gcc -Wall there are a lot of unused variables in >> plplot, if wanted I could provide a patch which removes those variables. > > Yes, please. Attached a patch which removes all unused variables in my configuration. I commented them out in 'examples/c/x32c.c' since the part that used them is also commented out. Regards, Mark de Wever ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel