On 2009-09-16 09:22+0100 Andrew Ross wrote:
>> There is one other place in our build system
>> 'remove_definitions("-DHAVE_CONFIG_H")' occurs and that is in
>> bindings/java/CMakeLIsts.txt. I don't know the purpose of that or even
>> whether it is necessary. Andrew, do you remember?
> I don't recall. I think it was copied from somewhere else. It is possible
> that config.h interferes with some of the C swig generated files, but it
> seems unlikely.
Hi Andrew:
It was good to hear from you again after your trip.
That question was generated by a grep for remove_definitions in all files of
our build tree. I actually didn't take a look at the file itself until now.
It has some commentary about why that remove_definitions is needed.
# Java compiler doesn't support -D option.
remove_definitions("-DHAVE_CONFIG_H")
That appears to be a pretty straightforward explanation, but I noticed this
remove_definitions appears at the end of the file where it probably did not
have any effect at all. So I tried dropping it, and on my gcj/gij platform
there were no issues. Anyhow, I have experimentally committed that change
(revision 10417), but if it causes problems for any java platform we should
reinstate the above again (at the top of the file so it is obvious to humans
it has an effect).
Alan
__________________________
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________
Linux-powered Science
__________________________
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
