Hi, Hazen, On Feb 10, 2010, at 18:02 , Hazen Babcock wrote:
> David MacMahon wrote: >> Moves the definitions of pltr0f and pltr2f (both declared in >> plplot.h) >> from the sccont.c files of the FORTRAN bindings into plcont.c. > > Could you elaborate briefly on what problem this patch solves? It moves the definition (i.e. implementation) of these functions into libplotd so that programs that include plplot.h (which already contains the declaration of these functions) and use these functions will link successfully. It seems not so great to have functions declared in plplot.h without having a definition of them in the corresponding library. Try this... $ grep '^pltr' include/plplot.h pltr0( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, PLPointer pltr_data ); pltr1( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, PLPointer pltr_data ); pltr2( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, PLPointer pltr_data ); pltr2p( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, PLPointer pltr_data ); pltr0f( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, void *pltr_data ); pltr2f( PLFLT x, PLFLT y, PLFLT *tx, PLFLT *ty, void *pltr_data ); $ nm tmp/src/libplplotd.dylib | grep pltr 0000d6cb T _pltr0 0000e2cd T _pltr0f 0000d6e8 T _pltr1 0000d85c T _pltr2 0000e2ff T _pltr2f 0000dda7 T _pltr2p I have this thread's patch applied so I see definitions in libplplotd for all six pltr* functions declared in plplot.h. If you do the same without this patch applied, you will only have four pltr* functions in libplplotd. An alternative "fix" would be to move the declarations from plplot.h into the FORTRAN bindings (where these functions were defined before this patch) . I wouldn't miss pltr0f if both its declaration and definition were in the FORTRAN bindings only, but I would very much miss pltr2f! Hope this clarifies things, Dave ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
