On 2010-07-22 04:09-0700 Jerry wrote: > On Jul 13, 2010, at 10:52 AM, Alan W. Irwin wrote: >> After that commit I can take over and do the necessary further changes >> to make those files non-configurable (from the CMake point of view), >> rename them without the *.cmake index in such a way that we do not >> lose svn history of those files, and commit all those further changes >> in such a way that we don't temporarily break PLplot. (That last issue >> has recently become important since we are using bisect methods to >> find regressions more and more, and commits that break PLplot >> interfere with that process unless you laboriously identify all such >> commits to the svn-bisect software.) > > Alan, > > I have just committed the changes that you describe--all affected Ada > files (68 out of 70) and cmake/modules/ada.cmake. I haven't tried a > (normal) build here but I have succeeded in doing my own private build > in my own development system (which bypasses all of the PLplot build > stuff) so I know the Ada code is OK. I hope you can make the changes > at your end because I suspect that otherwise the build will fail > (unless the ada.cmake edit overrides all new evil).
Thanks, Jerry. Despite your concern, the build and test continue to work fine after your changes. For example, on Linux "make test_diff_psc" produces this result: ada Missing examples : Differing postscript output : Missing stdout : Differing stdout : adathick Missing examples : Differing postscript output : Missing stdout : Differing stdout : The reason why it works is you have simply removed all configurable @whatever@ strings from the Ada files, but CMake configures those files anyway as a pure copy of the template file. And then the build and test proceeds as normal using those copied files as source. I will now strip out all this configuration machinery so that the template files are treated directly as source files with no need to copy them. A beneficial side benefit of that change is I will be able to rename all of them without the .cmake suffix. This strip out will take some time and care, but I hope to finish it (with similar good test results as above) by late today. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
