On 2011-10-31 20:48-0000 Andrew Ross wrote: > > I've been testing using the cmake support for building examples in the > install tree and encountered 3 bugs to do with references back to the > original plplot source / binary tree or problems using a separate > binary directory. > > For reference the recipe was something like > > mkdir build_examples > cd build_examples > cmake /path/to/plplot/share/plplot5.9.9/examples/ > make > > 1) ocaml: the examples/ocaml/CMakeLists.txt file checked whether > BUILD_SHARED_LIBS was set to see whether the rpath needed to be set. This > was never set in the install tree so the library and rpath information > was missing. This resulted in a linking error, unless the original > plplot binary tree was still present. Fix is to add BUILD_SHARED_LIBS > to the examples/plplot_configure.cmake_installed_examples.in file. > > 2) tk examples tried to call mktclIndex, but this was only present > if the original source tree was present. I've fixed this by installing > script/mktclIndex into the examples/tcl directory. Perhaps a tcl / tk > expert could comment whether this is really necessary, or should we > just use the installed version and remove calls to mktclIndex > > 3) finally, the tcl examples only copied the .tcl files over to a > separate binary directory if it the examples were being built in the > build tree, not in the install tree. This meant that the > standard_examples script failed in the the install tree case if the > examples were built in a separate binary directory. Fix is to copy > if different for both build tree and install tree cases. This also > ensure the mktclIndex script works in this case too. > > These problems only emerged because I tried this procedure after > installing the debian packages in a chroot environment to check the > install. Of course there was no plplot binary / source tree in that > case. Normally I would always have that still lying around so these > subtle bugs were missed. Moral: always be careful and thorough in > testing! >
Hi Andrew: Thanks for noticing these problems for the CMake-based build system when the source tree or build tree are not present and fixing them. I certainly agree with your moral at the end. Therefore, to make sure no such problems with dependence on the source tree and build tree creep back in for the CMake-based build system for the installed examples tree and to verify no such problems exist for the traditional build system for the installed examples tree, I suggest you follow up by modifying scripts/comprehensive_test.sh to _temporarily_ rename the source tree and build tree whenever either one of those two different build systems for the installed examples tree are being used. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ RSA® Conference 2012 Save $700 by Nov 18 Register now! http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
