On 2012-10-22 20:37+0100 Andrew Ross wrote: > > Phil, > > This all seems to work fine to me. I can't reproduce your bug with the old > code, but I suspect I'm not using the right lat / lon and / or map file. > The examples all work fine with your new code though. > > I've committed the changes to allow wider testing. The new data files are > larger (~5 times) but are higher quality. Still not excessive to > distribute.
It all works fine here (Debian wheezy platform) both with -DHAVE_SHAPELIB=OFF and (the default) -DHAVE_SHAPELIB=ON. Thanks, Phil for getting this idea to work so well in C code, and thanks Andrew for implementing the CMake support for this idea. When visually comparing the two cases it appears the code run with -DHAVE_SHAPELIB=ON (and presumably the shapelib form of the map files) produces slightly better looking results. For example, some of the Antarctica boundary is missing from the first page of example 19 when -DHAVE_SHAPELIB=OFF. But other than some minor improvements like that for the -DHAVE_SHAPELIB=ON case, the results are indistinguishable. Assuming others here also report good results I have three further questions: * Should we drop the non-shapefile map files and associated code during this current release cycle? I lean toward that solution since I suspect the non-shapefile map files and associated code were never used for anything serious. I would be perfectly willing to go along with the alternative of having an official deprecation period until at least the next release cycle before we remove the non-shapefile maps and associated code, but such an official deprecation period may be overkill. * Why do we need four shapefile map files for the current example 19? Couldn't we just adopt the (world) shapefile map file that is used for the first page of example 19 and range-limit and transform it as appropriate for the remaining pages of the example? Or am I missing something important? (This question has been motivated by my experience viewing a BC shapefile map that could be zoomed to show a lot of fine detail for the Victoria BC area where I live). * The current example 19 demonstrates only a minor advantage (improved Antarctica boundary and a few other slight rendering improvements) for the shapelib approach. Can we add a fifth page (only for the case when HAVE_SHAPELIB=ON) to example 19 that demonstrates a really beautiful shapelib map that knocks the socks off of users? In fact, I would suggest it was time to change all pages of example 19 to knock the socks off of users for the HAVE_SHAPELIB=ON case. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
