On 2014-10-07 06:49-0000 phil rosenberg wrote: > Hi this is just a quick email - I will reply properly later today
> I think the tests in the shell script are necessary - I am building natively under windows - that is the whole point - so I am using native Windows CMake and Tcl. However the test scripts are run with Bash. Cmake automatically detects my Cygwin Bash - presumably if I had MSys it would find Msys Bash. The point being that the tests are run under a different environment to the build. Thanks for that clarification. My confusion originated because you said something about Cygwin so I assumed that you were running tests on that pure platform which is, of course, very different from merely running the Cygwin (or MSYS) version of bash for your MSVC platform tests. Make sure, though, that Cygwin is absolutely last on your PATH so that CMake will never find anything else from Cygwin other than useful executables like bash to use for testing your MSVC platform case. I am virtually positive under those circumstances that CMake will not be confused as to platform so that the new PLATFORM variable in the configured plplot_test/test_tcl.sh file in the build tree should read MSVC in your case. > To get the correct path I need to find the environment that the tests are run under and the only way to do that 100% reliably is to do it in the shell script. Actually, I think CMake is the most reliable way to obtain the platform, but that should be completely distinct from what version of bash is being run (which is, I believe, what is supplied by uname). I agree with your principal point that you do have to identify the platform. So look at the PLATFORM variable set in the configured file to confirm that value is set correctly to MSVC in your case. Note, that when your PATH gives you access to Cygwin, CMake will find the Cygwin version of the components needed by PLplot if you don't supply them higher on your PATH or with guidance from CMAKE_LIBRARY_PATH and CMAKE_INCLUDE_PATH to avoid Cygwin libraries and headers. And such mixed Windows/Cygwin library results would be a disaster. So pay close attention to the output from CMake and also your CMakeCache.txt file to make sure you are not enabling any component of the build that is using Cygwin headers or libraries. That said, the Cygwin (or MSYS) version of bash and other executables should be fine to use for tests of the MSVC or any other Windows platform. > As I said I made every effort possible to maintain current behaviour for MSys and Cygwin builds... I think with my commit that aspect should be fine now. However, I now realize I went too far for the MSVC case and removed some of your bash logic that is likely important for that case because that logic would have also affected the Cygwin, MinGW, and MSYS platform cases. Feel free to restore anything I removed so long as the restored logic appears inside if [ "$PLATFORM" == "MSVC" ] ; then ... fi to assure your changes (including calls to uname to figure out bash version used to test the MSVC platform) have no effect on the other platforms. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
