Hi Phil,
I do not remember who wrote it, I may have made some changes to it in a now distant past, but I could have a look at your fix. Regards, Arjen > -----Original Message----- > From: Phil Rosenberg [mailto:p.d.rosenb...@gmail.com] > Sent: Monday, June 15, 2015 11:35 AM > To: plplot-devel@lists.sourceforge.net > Subject: [Plplot-devel] Bug in notcrossed() function of plfill.c > > Hi All > I have just been dealing with a bug where I was drawing a contour plot and my > entire > plot was being filled with one contour level. I have fought my way through > the code > and it turned out to be a perfect storm of a bug which begins with the > notcrossed > function returning a PL_NEAR_PARALLEL status for two lines which are actually > near perpendicular (and cross) which then causes the top left corner of my > plot to be > incorrectly labelled as inside a fill region. However because the fill region > is actually > outside the plot plplot sees no intersections with the plot boundaries so > checks if the > top left corner of the plot is inside the fill region. In this case it sees > that it is flagged > as inside so assumes the whole plot must be inside and fills the whole plot. > > I have fixed my code, but I actually don't understand the exixting logic > inside > notcrossed(). This might be because it is an error or it might be because I > just don't > get it. So before I push my change I just wanted to check if whoever authored > this > function is still around? > > Phil > > ------------------------------------------------------------------------------ > _______________________________________________ > Plplot-devel mailing list > Plplot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/plplot-devel DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
------------------------------------------------------------------------------
_______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
