Hi Phil It seems you got it working
I applied the patch, to 2 previous master commits that compile. results are: make VERBOSE=1 test_wxPLplotDemo 14:26:35: Debug: wxPLplotwindow::wxPLplotwindow 14:26:35: Debug: frame->Create 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: Plot() Yielding 14:26:35: Debug: wxPLplotwindow::OnCreate 14:26:35: Debug: Plot() So, we can just commit and push this patch -Pedro On 2016-12-19 13:59, Phil Rosenberg wrote: > On 19 December 2016 at 17:47, Pedro Vicente > <pedro.vice...@space-research.org> wrote: >> Hi Phil >> >>> Pedro can you please check if this works on your systems? >> >> >> ok, I'll try it when the patch is pushed to the master . >> >> Alan >> >> I assume you are going to push the patch? >> I get some compiling errors on the current master, please see my >> last post > > It would be good for you to test the patch before it gets pushed to > master so we don't contaminate master with useless changes that just > get undone next commit. To do so create a new branch from master, > then > apply the patch > git checkout master > git checkout -b myTestBranch > git apply path/to/patch.patch > > > If master is currently not working then try checking out a previous > commit as follows > git checkout master > git log > #select a working commit hash one or two back > git checkout <hash of previous commit> > git checkout -b myTestBranch > git apply path/to/patch.patch > >> >> a new idea: >> >> what about if we just override the Create() function of >> wxPLplotwindow ? > > Unfortunately we can't override the create function because we need > to > call the base class create function. We can't call the base class > create function inside our own create function because the parameters > that need to be passed in will differ depending upon whether you use > a > wxFrame, wxPanel or any other wxWindow as the template class that we > inherit from. In fact this is why we are using the create event in > the > first place, otherwise we would just sort everything in the > constructor. > > I'm pretty confident that the patch I sent will fix things if the > issue is just that the create event is delayed. If you are having > trouble getting it to apply, then I'll commit it to master. But I > guess we need to wait for Alan to fix the logging issues first. > > I'm about to leave work and head home. If he hasn't fixed them by the > time I open my laptop this evening then I'll have a look at fixing > the > issue myself. > > Phil -- Pedro Vicente pedro.vice...@space-research.org http://www.space-research.org/ ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
