Thanks Alan
I have a commit ready to go that removes a plexit call if the .fnt hershey font 
files are missing for some reason.

I'll wait for your uncrustify change then before I push it.

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Alan W. Irwin <alan.w.irwin1...@gmail.com>
Sent: Wednesday, July 24, 2019 9:40:16 AM
To: Phil Rosenberg <p.d.rosenb...@gmail.com>
Cc: PLplot development list <plplot-devel@lists.sourceforge.net>
Subject: Re: [Plplot-devel] uncrustify msys2

Hi Phil:

On 2019-07-23 18:44+0100 Phil Rosenberg wrote:

> Hi
> I just wanted to check if anyone on the list has used uncrustfy in
> msys2 to run the style-source script?

<aside> I am very happy to hear you are making progress with MSYS2, and I
look forward to your comprehensive test reports for that platform.</aside>.

>
> I couldn't find an uncrustify package to install via pacman, so I
> built it from source. However, when I run style_source.sh I get the
> following error
>
> Detected uncrustify version = 'Uncrustify-0.69.0_f'.
> This script only works with uncrustify 0.60.

Out of inertia I have stuck with uncrustify 0.60 up to now, but it is obviously
way past time to move to the latest version (0.69.0) so I have taken
responsibility for making that change.

One minor issue that I am currently looking at is the following (mild) warning
message I encountered from the CMake-based build system for uncrustify:

-- scripts/make_version.py exited with code 64: Unknown version control system 
in '/home/software/uncrustify/uncrustify-0.69.0'.

As a fallback, version 'Uncrustify-0.69.0_f' will be used.

Since the version string reported by you is
'Uncrustify-0.69.0_f' I assume your build has the same warning message.

I am virtually positive that warning is due to us both building from
the appropriate tarball rather than appropriate git tag, but I will
know a lot more tomorrow (after getting some sleep) after I finish
implementing a bash script to configure, build, install, and test from
the appropriate git tag corresponding to the desired uncrustify
version.  (For git enthusiasts like me such a build is actually easier
to do than a build from a tarball).  But my guess at this stage is
that script result will be the above minor issue will be fixed (since
git is virtually certainly the version control system that their build
system is looking for) and the uncrustify executable version string we
both encountered with the tarball build of 'Uncrustify-0.69.0_f' will
likely be replaced by 'Uncrustify-0.69.0'.  But I will see about that
version string tomorrow and see also the FIXME note below concerning
that.

Here is the PLplot commit message I have in mind for tomorrow (adapted
from the git commit message when I updated from 0.58 to 0.60 ~5 years
ago):

     Update from uncrustify version 0.60 to 0.69.0.

     This commit includes the following changes.

     1. Update annotated configuration file using
     uncrustify --update-config-with-doc -c uncrustify.cfg > 
uncrustify-0.69.0.cfg
     mv uncrustify-0.69.0.cfg uncrustify.cfg

     2. Update scripts/style_source.sh to change from 'uncrustify 0.60' for the
     allowed uncrustify version string to either 'Uncrustify-0.69.0' (built 
from appropriate
     git tag) or 'Uncrustify-0.69.0_f' (built from appropriate tarball) (FIXME 
if the git
     version of the build provides a version string different than 
'Uncrustify-0.69.0')

     3. Run that script to update the style of a large number of our source code
     files according to the uncrustify 0.69.0 rules.  We ascribe these large 
number
     of whitespace changes to changes in the implementation (new features
     with default configuration, bug fixes, and/or introduced bugs) between
     uncrustify 0.60 and 0.69.0.  Note that visual sampling of these changes 
didn't
     reveal any obvious style issues, and these changes also passed the test
     below:

     Tested by Alan W. Irwin <air...@users.sourceforge.net> on Linux
     (Debian Buster) by building the test_noninteractive target in the
     build tree and evaluating the result to demonstrate no build-time or
     run-time errors, and no issues with the SVG difference report.

Finishing implementing the uncrustify build, install, and test script
and all the above changes, tests, and test evaluations is obviously
going to take me a while, but it all appears to be entirely
straightforward so my current ETA for the above proposed commit is
late tomorrow (Wednesday) or so.

More then.

Alan
__________________________
Alan W. Irwin

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.org); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to