On 2019-07-24 01:40-0700 Alan W. Irwin wrote:

[...]so my current ETA for the above proposed commit is
late tomorrow (Wednesday) or so.

Sorry, but completely finishing this project will take much longer
than expected because of a complication with align_number_left (which
I have dealt with) and complications with styling the swig directive
(*.i) files that occur in bindings/<language> where <language> is one
of java, python, lua, or octave (which I have not been able to
completely deal with yet).

See the plplot-5.15.0-10-g16d554223 commit message for the details
concerning these complications.  (Use the --name-status option on git
log to insure you get a feel for the large number of files changed in
this commit.)

Although that commit skips styling the swig directive files, it is
otherwise complete so you should now be able to use
scripts/style_source.sh without issues on MSYS2 for either version
(one built from the appropriate git tag, one built from the
appropriate tarball) of uncrustify-0.69.0.  Therefore, please go ahead
and run that script on that platform for your version (built from
the tarball) of uncrustify-0.69.0, and let me know whether that script runs
without issues.

Also because the source code changes included in
plplot-5.15.0-10-g16d554223 are so intrusive it is important to make
additional tests beyond my own strong Linux platform test on non-Linux
platforms.  So along with the tests you normally perform for MSVC
please also try comprehensive testing on MSYS2 (at least for the
non-interactive case) to confirm these extensive source code changes
are not causing any trouble on that platform.

The other issue, of course, is all these source code changes introduce
conflicts for topic branches that have not been rebased to the lastest
master branch.  However, resolution of these conflicts should be
entirely straightforward since "git diff --ignore-all-space" showed
all the source code changes were simply whitespace changes.

Alan
__________________________
Alan W. Irwin

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.org); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________


_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to