On 2010-01-06 16:38-0500 Hazen Babcock wrote: > [...]I also ran uncrustify on the > file since we seem to be using a tab spacing that is not the emacs default. > Unfortunately this seems to have introduced a lot of other changes unrelated > to the changes that I actually made, which were only to the plP_text > function.
Were you using "scripts/style_source.sh --apply"? That script should style all our files with uncrustify in the proper way including no tabs anywhere. When I ran "scripts/style_source.sh --diff -au |less" here I found there were some incorrect whitespace changes introduced by your commit which I fixed by running "scripts/style_source.sh --apply" (revision 10739). If you want to find out more about that script, please run "scripts/style_source.sh --help". As a check please run "scripts/style_source.sh" now with no options for revision 10739. Assuming nothing is wrong with your version of uncrustify, it should give no result at all indicating all our C, C++, D, and Java source files have the correct style as specified by uncrustify.cfg in the top-level source tree directory. Do you obtain that good null result? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Plplot-general mailing list Plplot-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-general
