andyg;374703 Wrote: > SaverSwitcher: Not OK, it has an external dependency on CGI.pm which is > not included with SC. Since only 2 functions are used anyway, and > CGI.pm is a memory hog, these should be handled another way. This > plugin also makes use of a large amount of global variables, and should > be refactored to use less. $client->pluginData should be used instead.
Thanks. I'll switch from CGI to URI::Escape. I think CGI.pm is effectively included with SqueezeCenter though -- it's been in Perl core since early Perl 5, and I've had no error reports about this, not even from Windows users. Maybe ActiveState is including CGI.pm code in the released EXE that you'd rather it leave out? Anyhow, I'm happy to switch, and I appreciate your review. There's nothing I can do about the global variables right now though, as per our discussion of $client->pluginData being tied to sync groups rather than specific clients. Is my use of globals a dealbreaker for including SaverSwitcher? -Peter -- peterw http://www.tux.org/~peterw/ free plugins: http://www.tux.org/~peterw/#slim AllQuiet BlankSaver ContextMenu FuzzyTime KidsPlay KitchenTimer PlayLog PowerCenter/BottleRocket SaverSwitcher SettingsManager SleepFade StatusFirst SyncOptions VolumeLock ------------------------------------------------------------------------ peterw's Profile: http://forums.slimdevices.com/member.php?userid=2107 View this thread: http://forums.slimdevices.com/showthread.php?t=56697 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/plugins
