-1
I couldn't find pluto-3.0.1 tag in
https://git-wip-us.apache.org/repos/asf/portals-pluto.git. I wonder
how the release candidate artifacts were made. The master branch's
version was not bumped up to 3.0.2-SNAPSHOT either.
Even worse, there's a stopper in the root pom.xml [1]:
<profile>
<id>liferay</id>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.liferay.portal</groupId>
<artifactId>com.liferay.cdi.bean.portlet.extension</artifactId>
<version>1.0.0-SNAPSHOT</version>
</dependency>
</dependencies>
</dependencyManagement>
<repositories>
<repository>
<id>liferay-snapshots</id>
<name>Liferay Snapshots</name>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
</repositories>
</profile>
Releases must not depend on a SNAPSHOT dependency. And the
com.liferay.cdi.bean.portlet.extension artifact has no clear copyright
notice. So this is not acceptable.
If the 'liferay' profile is necessary for Liferay specific TCK
testing, I'd recommend you to move it out to a special documentation
explaining how to run Liferay specific TCK testing by configuring
those in user's settings.xml instead, not in the source distribution.
Regards,
Woonsan
[1]
https://git-wip-us.apache.org/repos/asf?p=portals-pluto.git;a=blob;f=pom.xml;h=1fb14997be03c4911ce97ebf0826f59f599a2198;hb=HEAD#l739
On Fri, May 11, 2018 at 3:06 PM, Neil Griffin
<neil.grif...@portletfaces.org> wrote:
> Dear Apache Portals Pluto Team and community,
>
> I've staged a release candidate for the new Apache Portals Pluto 3.0.1
> release.
>
> This release candidate includes:
>
> * Fully compliant Reference Implementation of the new Portlet 3.0
> Specification per JCR-362
> https://www.jcp.org/en/jsr/detail?id=362
> * Fully completed (and corrected) TCK (Test Compatibility Kit) for Portlet
> Spec 3.0
> * Updated portlet-api with associated Javadoc improvements
> * General bugfixes
> * Updated archetypes
>
> Please review the release candidate for this project which is spread
> across the following THREE maven staging repositories:
>
> 1) portlet-api and pluto-portal components and dependencies:
> https://repository.apache.org/content/repositories/orgapacheportals-1018
>
> 2) pluto+tomcat bundle:
> https://repository.apache.org/content/repositories/orgapacheportals-1019
>
> (The bundle can be tested by unzipping it,
> and running start.sh from the bin directory,
> then navigating to http://localhost:8080/pluto
> and login as pluto/pluto.)
>
> 3) maven archetypes:
> https://repository.apache.org/content/repositories/orgapacheportals-1020
>
> The Release Notes are available here:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10560&version=12338908
>
> The KEYS file to verify the release artifacts signature can be found here:
>
> https://dist.apache.org/repos/dist/release/portals/pluto/KEYS
>
> Please review the release candidates and vote on releasing Apache Portals
> Pluto 3.0.1
>
> Seeing as how I am sending this on a Friday, the normal vote of 72 hours
> seems unreasonable. Therefore I would like to extend the vote to 96 hours.
>
> Please cast your vote:
>
> [ ] +1 for Release
> [ ] 0 for Don't care
> [ ] -1 Don't release (do provide a reason then)
>
>
> Best Regards to all,
>
> Neil
