On Mon, Mar 12, 2007 at 12:36:23PM +0100, Frank Seidel wrote:
> On Tuesday 20 February 2007 19:46:57 Stefan Seyfried wrote:
> > Hi,
> >
> > This adds basic support for uswsusp (http://suspend.sf.net)
> >
> > More work needs to be done let the s2ram use the newly added
> > commandline parameters.
> Hi,
> i'd also vote for this patch. Just some small additional comments..
>
> >
> > Index: pm/functions
> > ===================================================================
> > RCS file: /cvs/pm-utils/pm-utils/pm/functions,v
> > retrieving revision 1.32
> > diff -u -r1.32 functions
> > --- pm/functions 30 Nov 2006 20:07:04 -0000 1.32
> > +++ pm/functions 20 Feb 2007 18:43:43 -0000
> > @@ -12,6 +12,9 @@
> > INHIBIT=/var/run/pm-utils.inhibit
> > PM_LOGFILE=${PM_LOGFILE:=/var/log/pm-suspend.log}
> > SUSPEND_MODULES=""
> > +HIBERNATE_METHOD=""
> > +S2DISK_BIN=/usr/sbin/s2disk
> Why not also add S2RAM_BIN here like..
>
> +S2RAM_BIN=/usr/sbin/s2ram
It is IMO not really needed.
The reason why i did the S2DISK_BIN at all was that you can configure it to
use s2both instead of s2disk.
Since s2both needs similar preparation (select grub entry, check for swap,
check the config file, etc.) as s2disk, it does not really make sense to
replace s2ram with s2both, you can only replace s2disk with s2both.
If we get HAL to recognise that there is more than just "suspend" and
"hibernate", but also s2both, then we will probably just have a third
"suspend mode" added to pm-utils and won't need to have this configurable
at all.
All IMHO, of course :-)
Thanks for reviewing,
Stefan
--
Stefan Seyfried
"Any ideas, John?"
"Well, surrounding them's out."
_______________________________________________
Pm-utils mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pm-utils
