On Sat, 2008-03-15 at 21:18 +0100, Michael Biebl wrote: > 2008/3/15, Victor Lowther <[EMAIL PROTECTED]>: > > I think it is time to do a release. I have been running the latest > > version of pm-utils on my laptop for a little over a week, and I have > > had exactly 0 suspend/resume failures related to pm-utils in that > > time. > > Found a bug in the disable_hook logic: > # cat /etc/pm/config.d/mode > SLEEP_MODULE="uswsusp" > # pm-hibernate --help > ... > Sa 15. Mär 21:13:57 CET 2008: running /usr/lib/pm-utils/sleep.d/99video help > disabled. > # echo SLEEP_MODULE="kernel" >> /etc/pm/config.d/mode > # pm-hibernate --help > ... > Sa 15. Mär 21:13:57 CET 2008: running /usr/lib/pm-utils/sleep.d/99video help > disabled. > > Problem is, that disable stores the disabled hooks as files: > /var/run/pm-utils/storage/disable_hook\:99video
Yay, a bug! It seems that in this case, there are two bugs: 1. We are still emitting the run_hooks diagnostic messages even though we should not be when running with help. 2: The storage directory is not getting cleaned properly between runs. > Imho, this information should be stored in an environment variable Yeah, I briefly tried using an environment variable for store the hooks, but it only works if we do not try to disable a hook from a subshell. Since I can think of a few scenarios where we might want to do that (one hook disabling another is the big one), I discarded that approach. > Cheers, > Michael -- Victor Lowther Ubuntu Certified Professional _______________________________________________ Pm-utils mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pm-utils
