On Sat, 2008-03-15 at 15:54 -0500, Victor Lowther wrote: > On Sat, 2008-03-15 at 21:18 +0100, Michael Biebl wrote: > > Found a bug in the disable_hook logic: > > # cat /etc/pm/config.d/mode > > SLEEP_MODULE="uswsusp" > > # pm-hibernate --help > > ... > > Sa 15. Mär 21:13:57 CET 2008: running /usr/lib/pm-utils/sleep.d/99video help > > disabled. > > # echo SLEEP_MODULE="kernel" >> /etc/pm/config.d/mode > > # pm-hibernate --help > > ... > > Sa 15. Mär 21:13:57 CET 2008: running /usr/lib/pm-utils/sleep.d/99video help > > disabled. > > > > Problem is, that disable stores the disabled hooks as files: > > /var/run/pm-utils/storage/disable_hook\:99video > > Yay, a bug! > > It seems that in this case, there are two bugs: > 1. We are still emitting the run_hooks diagnostic messages even though > we should not be when running with help.
OK, this will be an easy fix. Some of the log() stuff got lost during the merges. > 2: The storage directory is not getting cleaned properly between runs. This is happening because pm-action does not take the suspend lock when running to display help, and the storage directory only gets cleaned when the suspend lock is released. I have pushed fixes for both of these issues upstream. -- Victor Lowther Ubuntu Certified Professional _______________________________________________ Pm-utils mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pm-utils
