Le 03/09/2012 10:01, Kalle Raiskila a écrit :
> 03.09.2012 10:53, ext Vincent Danjean skrev:
>
>>> -a libOpenCL->libpocl link can be made if exporting is enabled, adding
>>> this check to the currently available ones. Perhaps even with a user
>>> override to dissallow?
>>
>> I would propose that this link requires an explicit separate configure
>> option. By default, as proposed, we will build ICD and export symbols.
>> But, by default, we wont want that 'make install' overwrite libOpenCL.so
>> installed in the system (ICD loader).
>
> I think the current checks check for the exsitance of libOpenCL before
> making the link. Why did we want this link there in the first place?
The check was done at install time (I think I removed this installation
in one commit) and it is wrong in case of the use of DESTDIR.
Moreover, it will be difficult to make "make distcheck" pass if
libOpenCL link is sometimes installed, sometimes not.
We can make the configure option I proposed having its default
depending on whether libOpenCL.so is present or not.
>> Note that the "-Wl,-z,defs" linker option I use will warn the developer
>> immediately if he uses a undefined symbol (ie clXXX instead of POclXXX).
>> It is the way I found all the clXXX to replace.
>
> Ok, lets add those, if not already in the proposed merge branch.
It is in the proposed merge branch. However, it is directly
in Makefile.am. Perhaps, we need to move it in configure.ac if not
all system support this linker option (that is more an help for
the developer than a requirement for correctness)
Regards,
Vincent
> kalle
>
--
Vincent Danjean Adresse: Laboratoire d'Informatique de Grenoble
Téléphone: +33 4 76 61 20 11 ENSIMAG - antenne de Montbonnot
Fax: +33 4 76 61 20 99 ZIRST 51, avenue Jean Kuntzmann
Email: [email protected] 38330 Montbonnot Saint Martin
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
pocl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pocl-devel
