Le 09/01/2013 09:52, Pekka Jääskeläinen a écrit :
> On 01/09/2013 03:10 AM, Vincent Danjean wrote:
>> I'm really interrested to know if this last patch works anywhere or not.
>
> This doesn't apply cleanly anymore to the 0.7 branch (and the latest rc)
> as most of it is applied already (all except for the llvm-config call
> removal).
The one from the Debian git repo is applied on 0.7-rc5.
>> Here is a patch that try to solve this. It also move internal scripts
>> and tools out of bindir (scripts are moved to pkgdatadir and
>> program to pkglibexecdir).
>
> It looks a bit too intrusive so I rather not apply it to 0.7 at this
> stage of the release. I'll apply it to trunk so it
> gets more testing during the 0.8 development cycle. Should be OK
> as you seem to have it in the debian package patch list.
ok. As said, I think I will keep it for the Debian package.
>> Then, when digging into source/build system, I see several things
>> I want to ask you if this is normal or not.
>>
>> 1) poclu is installed into /usr/include *and* /usr/include/pocl
>
> No. Should be fixed.
>
>> 2) some installed headers are required for running OpenCL programs
>> while some others are provided to write new devices, ...
>> In my packaging, I put the first ones with the library itself
>> and the second ones into a separate devel package.
>> Can you check that my split is correct?
>> I put with the library pocl/_kernel.h and pocl/*/types.h
>> I put in the devel package poclu.h, pocl/pocl_device.h,
>> pocl/utlist.h, pocl/poclu.h and pocl/pocl.h
>
> I'm not sure are any of these headers are required to be installed
> or included in the packages as everything (including the device drivers)
> is built in libpocl and it's not supposed to be possible (yet!) to develop
> device drivers outside the pocl tree and add them as plugins or similar.
> I.e. the cl.h etc. should be enough.
Ok. So, I will keep pocl/_kernel.h and pocl/*/types.h (that are required
for building/running a OpenCL program with POCL) and wait for you feedback
about all other headers.
> I'll try to clean these up (define what is really needed to
> be installed more strictly) in the devel branch.
I will backport this in the Debian package.
>> 3) in lib/CL/devices/tce/tce_common.cc, there is a reference to
>> SRCDIR. Will this still work if sources are removed after installation?
>> std::string("tcecc --vector-backend -llwpr -I ") + SRCDIR +
>> "/include " + deviceMainSrc + " " +
>> Note that I do not use tce, so I cannot check.
>
> It should work, it's just an additional (possibly useless) include
> search path. I'll check.
Here again, as for path lookup, consider security issue. If a malicious
user can replace/recreate the source tree with its own files (because
it was in /tmp for example), this can be problematic.
As this is in TCE, it is not currently a problem for the Debian package.
>> 4) debian llvm-3.2 package seems to be built with -fno-rtti.
>> If this is really a problem for pocl (the basic testsuite pass, is it
>> really required?) then I will need to ask llvm maintainers to change
>> this (and hope they accept)
>
> I once asked them to enable it and they did but I think it was for the
> Ubuntu package (IIRC Debian didn't include the LLVM package at that
> point).
[...]
Thank for the info. I will open a bug in the Debian BTS about this.
>> PS: due to my work schedule, it will be very difficult for me to
>> continue to work on pocl during the next 2 weeks. If some of you
>> want to test
>
> ... ? This sentence was not finished.
Oups, it was too late ;-)
Injust want to say that *Debian packages* of pocl can be tested as sources
are available here:
http://git.debian.org/gitweb/?p=collab-maint/pocl.git
Regards,
Vincent
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
pocl-devel mailing list
pocl-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pocl-devel
