On Jun 8, 2014, at 17:13 , Pekka Jääskeläinen <[email protected]> wrote:
> On 06/08/2014 10:11 PM, Erik Schnetter wrote: >> We currently provided some kernel functions for the half data type. For many >> of >> these, LLVM would fail to generate machine code from byte code. I removed >> those >> functions that the standard does not require. > > Please do not remove the half functions! > I have just added some of those recently as we needed them > in our benchmark cases. > > We use them heavily in our group where we design > cores that support native computation with halfs. > > It's a standard extension in OpenCL: > http://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/cl_khr_fp16.html > > The correct way is to disable them conditionally for devices that do > not support halfs natively (and thus fail to generate code for them). > Perhaps, in addition to __IF_FP16, we need __IF_NATIVE_FP16? That is a good idea. > x86_64 doesn't support computation on halfs, but even in that case > it can be useful to emulate native computation to test kernels that > use halfs natively. But that's another story. > > So, please revert until a proper fix is found (and before someone > in our group accidentally merges this and breaks our project cases). Done. -erik -- Erik Schnetter <[email protected]> http://www.perimeterinstitute.ca/personal/eschnetter/ My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu/.
signature.asc
Description: Message signed with OpenPGP using GPGMail
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech
_______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
