On 06/09/2014 02:04 AM, Erik Schnetter wrote:
> I re-pushed my changes to a new branch "fp16-api". There, I left the fp16

I created a merge request out of it so I could add some inline comments to
the diff. I browsed it rather quickly (I need to go soon) and added a
couple of comments.

> functions enabled, guarded by a new #ifdef FP16_API. This is enabled by
> default, but should probably be autoconfigured in the future. Can you have a
> look at this branch?

I'm not sure should we have two macros after all.

If OpenCL specs mandates to have the storage support for half, shouldn't it
be enabled by default and just have a macro (and autoconf check) for the
native compute (the fp16 extension) support? The TCE device driver should
have it on by default for now.

> I would like to disable the fp16 API for x86-64 in the future.

Yes, the native fp16 support macro should be disabled by default.

-- 
--Pekka


------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://www.hpccsystems.com
_______________________________________________
pocl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pocl-devel

Reply via email to