On 06/18/2014 09:45 AM, Michal Babej wrote: > So, about merging to master... I did a few changes in the cmake branch > that touch the code as well. If we want to keep both autotools and > cmake, i need to revert them (or adapt autotools to them).
Yes, let's keep both build systems usable fow now. > Most are in commit 9160a3323: > > - remove install-paths.h references (most are unused anyway); > replace PKG*DIR variables from install-paths.h with defines from > config.h config.h is generated at configure time. install-paths.h is generated at build time. This is because one can override DESTDIR at the make command line. https://www.gnu.org/prep/standards/html_node/DESTDIR.html Actually, I'm not sure should we do it this way around. If the packager uses DESTDIR, he won't run pocl from the DESTDIR, but only from the prefix (the final installation location), thus install-paths.h should reflect them? > - replace PACKAGE_VERSION with POCL_VERSION Did this break something? > - replace CLFLAGS with KERNEL_CL_FLAGS, and CLANGXX_FLAGS with > KERNEL_CLANGXX_FLAGS - they seem more fitting and less confusing > (with LLVM_{CXX,C,CL}FLAGS being values from llvm-config) OK. > - changed TARGET_{LLC,CLANG}_FLAGS into > {CELL,TCE}_TARGET_{LLC,CLANG}_FLAGS - seems more consistent > wrt >1 ocl "targets" Makes sense. > - removed {TARGET,HOST}_SIZEOF_<type> defines, they all seem unused; > there is some code using SIZEOF_<type> defines though. > > The first two i probably must revert for autotools, the latter three i > need to hear your ideas.. > > Looking at the last item (SIZEOF), seems only used in > lib/CL/devices/pthread/pthread.c to enable/disable half and double > extensions... Yes, those should be left there so the "CPU" device drivers adapt to the features of the CPU being used. -- Pekka ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ pocl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pocl-devel
