Re: [Podofo-users] PdfWriter as a base class

Ilan Zisser Mon, 12 May 2014 05:17:28 -0700

I didn't see this. My revision didn't include PdfSigIncWriter.h.
The reason for the warning is obvious, missing "virtual" before the method Write.
A patch is attached.

Ilan

On 5/11/2014 19:15, zyx wrote:

On Mon, 2014-05-05 at 10:20 +0300, Ilan Zisser wrote:

Attached is a patch file that modifies PdfWriter.h. It makes PdfWriter
usable as a base class.

	Hi,
I applied the patch to the current trunk and there are new warnings
introduced by the change. Those are:


        [  1%] Building CXX object src/CMakeFiles/podofo_static.dir/base/PdfSigIncWriter.cpp.o
        In file included from podofo-trunk/src/base/PdfSigIncWriter.h:37:0,
                         from podofo-trunk/src/base/PdfSigIncWriter.cpp:34:
        podofo-trunk/src/base/PdfWriter.h:103:18: warning: ‘virtual void PoDoFo::PdfWriter::Write(PoDoFo::PdfOutputDevice*)’ was hidden [-Woverloaded-virtual]
             virtual void Write( PdfOutputDevice* pDevice );
                          ^
        In file included from /podofo-trunk/src/base/PdfSigIncWriter.cpp:34:0:
        /podofo-trunk/src/base/PdfSigIncWriter.h:50:10: warning:   by ‘void PoDoFo::PdfSigIncWriter::Write(PoDoFo::PdfOutputDevice*, PoDoFo::pdf_int64)’ [-Woverloaded-virtual]
             void Write( PdfOutputDevice* pDevice, pdf_int64 prevOffset);
                  ^

and few more also related to SigInc classes. Would you mind to address
those new warnings, please?
	Bye,
	zyx

Index: PdfSigIncWriter.h
===================================================================
--- PdfSigIncWriter.h   (revision 1599)
+++ PdfSigIncWriter.h   (working copy)
@@ -47,7 +47,7 @@
 
     virtual ~PdfSigIncWriter();
 
-    void Write( PdfOutputDevice* pDevice, pdf_int64 prevOffset);
+    virtual void Write( PdfOutputDevice* pDevice, pdf_int64 prevOffset);
 };

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs

_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Re: [Podofo-users] PdfWriter as a base class

Reply via email to