Hi all,

attached to this e-mail is a patch which clarifies the parameters of
PdfFontFactory::CreateBase14Font() in an effort to prepare the method
for being documented (I'll do that too when I can just svn update to get

this one). Please review this patch, if accepted, please apply it
separately to the public repository, if not, please tell me why not.
I'll probably have time for documenting next tomorrow afternoon.

Best regards, mabri
Index: src/doc/PdfFontFactory.cpp
===================================================================
--- src/doc/PdfFontFactory.cpp	(revision 1680)
+++ src/doc/PdfFontFactory.cpp	(working copy)
@@ -351,14 +351,17 @@
 	return found ? &PODOFO_BUILTIN_FONTS[i] : NULL;
 }
 
-PdfFont *PdfFontFactory::CreateBase14Font(const char* pszFontName, int nFlags, const PdfEncoding * const pEncoding, PdfVecObjects *pvecObjects)
+PdfFont *PdfFontFactory::CreateBase14Font(const char* pszFontName,
+                    EPdfFontFlags eFlags, const PdfEncoding * const pEncoding,
+                    PdfVecObjects *pParent)
 {
-   PdfFont *pFont = new PdfFontType1Base14(PODOFO_Base14FontDef_FindBuiltinData(pszFontName), pEncoding, pvecObjects);
-   if (pFont) {
-      pFont->SetBold( nFlags & ePdfFont_Bold ? true : false );
-      pFont->SetItalic( nFlags & ePdfFont_Italic ? true : false );
-   }
-   return pFont;
+    PdfFont *pFont = new PdfFontType1Base14(
+        PODOFO_Base14FontDef_FindBuiltinData(pszFontName), pEncoding, pParent);
+    if (pFont) {
+        pFont->SetBold( eFlags & ePdfFont_Bold ? true : false );
+        pFont->SetItalic( eFlags & ePdfFont_Italic ? true : false );
+    }
+    return pFont;
 }
 
 };
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to