On Thu, 2015-10-01 at 21:50 +0000, Matthew Brincke wrote:
> -PdfFont *PdfFontFactory::CreateBase14Font(const char* pszFontName, int
> nFlags, const PdfEncoding * const pEncoding, PdfVecObjects *pvecObjects)
> +PdfFont *PdfFontFactory::CreateBase14Font(const char* pszFontName,
> + EPdfFontFlags eFlags, const PdfEncoding * const
> pEncoding,
> + PdfVecObjects *pParent)
Hi,
I would not change that type of nFlags, it's not a good idea:
a) I get build break due to not changed prototype in the header file
b) even if I fix it, I get a build break due to no cast from int to
the enum, for example called from PoDoFo::PdfFontCache::GetFont()
I can have set my gcc too strict, but I do not think it's that much
strict. After all, you do not pass one value of the enum, but a bit-or
of them, which the 'int' works for pretty well (or 'unsigned int' can,
in some cases with many enum values).
Bye,
zyx
--
http://www.litePDF.cz [email protected]
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
