Hi all! I added a conditional #if to check Tiff-version
#if TIFFLIB_VERSION >= 20120922 // TiffOpenW needs at least version 4.0.3 in revision 1710 because older version don’t support TiffOpenW and thus LoadFromTiff with wchar is not available. This #if didn't work if tiffio.h was not included. So in revision 1715 this include was introduced by Dennis Voss. I think it's good to remove the include tiffio.h from the header, because otherwise every caller of PdfImage would need access to the tiff-header-path and we are getting problems with windows.h drawing winsock.h instead of winsock2.h. I you share my view, I would remove the include and the #if TIFFLIB_VERSION in the header and let LoadFromTiff with wchar raise an error if the TIFFLIB is too low. So everything is encapsulated in the cpp Uli -----Ursprüngliche Nachricht----- Von: a...@users.sourceforge.net [mailto:a...@users.sourceforge.net] Gesendet: Freitag, 13. Mai 2016 12:29 An: podofo-...@lists.sourceforge.net Betreff: [Podofo-svn] SF.net SVN: podofo:[1728] podofo/trunk/src/doc/PdfImage.h Revision: 1728 http://sourceforge.net/p/podofo/code/1728 Author: aja_ Date: 2016-05-13 10:28:35 +0000 (Fri, 13 May 2016) Log Message: ----------- Remove unneeded include of tiffio.h in PdfImage.h Modified Paths: -------------- podofo/trunk/src/doc/PdfImage.h Modified: podofo/trunk/src/doc/PdfImage.h =================================================================== --- podofo/trunk/src/doc/PdfImage.h 2016-05-12 20:25:45 UTC (rev 1727) +++ podofo/trunk/src/doc/PdfImage.h 2016-05-13 10:28:35 UTC (rev 1728) @@ -38,10 +38,6 @@ #include "podofo/base/PdfFilter.h" #include "PdfXObject.h" -#ifdef PODOFO_HAVE_TIFF_LIB -# include "tiffio.h" -#endif // PODOFO_HAVE_TIFF_LIB - namespace PoDoFo { class PdfArray; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
