On Fri, 2016-05-13 at 15:15 +0200, Ulrich Arnold wrote:
> I you share my view, I would remove the include and the #if
> TIFFLIB_VERSION in the header and let LoadFromTiff with wchar raise
> an error if the TIFFLIB is too low. So everything is encapsulated in
> the cpp
Hi,
sounds good to me. Please do it. And I'm sorry of the overlook (if the
compiler is happy, it's harder to spot things without extensive unit
testing).
Alternatively, you can add a function check in the CMake files and
provide HAVE_TIFFOPENW in the podofo_config.h and depend on it, instead
of the version check and the include. Or do the version check from the
CMake. There are several options how to keep before-r1728 behaviour.
Nonetheless, as I said, the new behaviour is fine with me too.
Thanks and bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
