On Mon, 2016-05-09 at 15:25 +0000, Matthew Brincke wrote:
> -    if( m_pPrev && m_pNext ) 
> +    if( m_pPrev ) 
>      {
> -        m_pPrev->SetNext    ( m_pNext );
> +        m_pPrev->SetNext( m_pNext );
> +    }
> +
> +    if( m_pNext ) 
> +    {
>          m_pNext->SetPrevious( m_pPrev );
>      }
>  

        Hi,
I would commit only part of your patch for the next release, all but
the added ref counting and the mutex, because the above quoted change
shows a coding error, which you fixed. The committed part would not be
only this chunk, but more of them.

If there is no objection, then I'll commit it at the end of this week.

The change itself will not fix the crash from the reporter, such thing
needs new method(s) added into the PdfOutlineItem, to move/copy
the items in the "tree", rather than only create new children with new
subtree.
        Bye,
        zyx

-- 
http://www.litePDF.cz                                 i...@litepdf.cz

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to