On 25.5.2016 23:21, zyx wrote:
> On Sun, 2016-05-22 at 14:39 +0200, zyx wrote:
>> This looks like a typo and if no objection is given, I'll revert
>> this chunk at the beginning of the next week.
>
> I did the revert as revision 1757:
> http://sourceforge.net/p/podofo/code/1757
Hi,
I noticed during the release candidate 2 testing that this is still
broken. The above revert reverted only the second chunk of the [r1714]
in the PdfDifferenceEncoding.cpp, which helped with some letters, but
not with all. If I revert also the first chunk there, then it behaves
the same as PoDoFo 0.9.3, which means correctly for the Adobe Reader.
I reverted more in the [r1762], which broke the EncodingTest unit test
again. I think the issue is somewhere else, though, as there are too
many conversions between the big endian and the little endian, making
the code very hard to follow, not talking about the possibility of
having the unicodeValue 0 in the call of
PdfEncodingDifference::AddDifference() which can break
PdfEncodingDifference::ContainsUnicodeValue(), because it relies on it
being set.
I didn't investigate the issue too much into detail, thus the above
statements can be false. My main focus was to avoid regression from
the 0.9.3 release in the 0.9.4 release, thus I went ahead and reverted
the bits which caused the regression. Note that the regression exhibits,
for example, for letters with the code 0x81, 0x83, 0x88, 0x8C, 0x8D,
0x8F, but not for other letters in the 0x80..0x8F range. The
PdfPainter::DrawText() writes "<>" to the drawing stream for them.
I didn't spot any other issues with my smoke tests of the release
candidate 2.
Bye,
zyx
[r1714] http://sourceforge.net/p/podofo/code/1714
[r1762] http://sourceforge.net/p/podofo/code/1762
--
http://www.litePDF.cz [email protected]
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
