On Mon, 2017-01-16 at 15:34 +0000, Jaseem Ali K T wrote:
> I may send a proper fix with all the changes, but I am also OK if
> anyone else does it.
Hi,
I'm not sure what you mean, really. The PdfPainter has like 1973 lines
and you pasted into the message, nicely colorized, piece of code of 10
lines out of nowhere. Do you expect that others have time to redo what
you've already done? Of course proper fixes are preferred.
Do not take me wrong, I appreciate the involvement you have in the
PoDoFo, but please do understand that if everyone would just reference
the code in some similar way instead of sending proper unified diffs,
then it would require quite some work for the committer to do it right,
instead of just running one simple command to apply the change and be
sure that it results the same state as on the sender's side.
And if you'll add a test for it, then that's for bonus points.
Thank you for your understanding.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
