Hi
For now I am sending only the fix, which is just an one line change. Since this is crash issue, I believe the fix has to be immediately applied. My intention was always to send the diff and also to indicate if someone can provide better solution, or find other problems etc. The rules followed in multiline text are roughly as follows Put as many letters in each line starting from the beginning of the text. If a word doesn't fit in a line , move it to the next line. If a word-width is more than the width of rectangle, split it. If the width is less than the width of letter itself, put the letter in the line rather than moving it to next. Avoid line starting with white spaces , except for the first line and the cases where the width is less than width of a letter. Regards Ali -----Original Message----- From: zyx [mailto:z...@litepdf.cz] Sent: Monday, January 16, 2017 9:58 PM To: podofo-users@lists.sourceforge.net Subject: Re: [Podofo-users] Multiline Text Bug On Mon, 2017-01-16 at 15:34 +0000, Jaseem Ali K T wrote: > I may send a proper fix with all the changes, but I am also OK if > anyone else does it. Hi, I'm not sure what you mean, really. The PdfPainter has like 1973 lines and you pasted into the message, nicely colorized, piece of code of 10 lines out of nowhere. Do you expect that others have time to redo what you've already done? Of course proper fixes are preferred. Do not take me wrong, I appreciate the involvement you have in the PoDoFo, but please do understand that if everyone would just reference the code in some similar way instead of sending proper unified diffs, then it would require quite some work for the committer to do it right, instead of just running one simple command to apply the change and be sure that it results the same state as on the sender's side. And if you'll add a test for it, then that's for bonus points. Thank you for your understanding. Bye, zyx -- http://www.litePDF.cz i...@litepdf.cz ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users ::DISCLAIMER:: ---------------------------------------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects. ----------------------------------------------------------------------------------------------------------------------------------------------------
PdfPainter.diff
Description: PdfPainter.diff
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
