Hi all, hello Etienne, I'd like to give some comments about the patches:
- PdfEncoding::GetUnicodeValue() is protected, yes, but the parameter name "value" is missing (it looks in the header file as if it's unused). - The loop in the method is (at least) strongly recommended to be a "while" and not a "for" loop because the loop variable iSrc is changed inside the loop. - Most importantly, AFAIK the two uses of reinterpret_cast to pdf_uint8* break the strict aliasing rule because that isn't a pointer to (unsigned) char when <stdint.h> is detected by cmake (otherwise it is ...) (see e.g. http://en.cppreference.com/w/cpp/language/reinterpret_cast under the heading "Type aliasing"), therefore it's undefined behaviour, i.e. can/ will go haywire at minimum when optimizing, probably also without it. Could you please take these into account? Best regards, mabri ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
