On Thu, 2017-03-02 at 00:00 +0100, Matthew Brincke wrote:
>
> I'm sorry that have only build-tested it a bit yet, still I'm submitting
> the patch to PdfOutlineItem to correct memory management for review.
Hi,
you know, such statements sound quite discouraging. If you are not
willing to test your own patches, then why should do it anyone else? I
can understand it for a straightforward changes, but not for anything
more complicated. By the way, as a bonus, writing unit test for the
change(s) would be more than welcome.
> Now the item given to InsertChild() is copied and the pointers are set to
> NULL so that only that bare item is inserted, no deep copying or problems
> with referenced items being reachable/erasable from two different trees.
This doesn't sound correct to me, but I cannot tell yet. The attached
patch was incomplete, caused a build break at the best.
> Please consider review/testing/when appropriate applying to the public
> repository.
No need to mention this, it's somehow understood on its own (at least
by me, on this list).
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
