On Tue, 2018-02-27 at 15:25 +0200, Yurii Olenych wrote: > +void PdfPage::SetICCProfile(const char *pCSTag, PdfInputStream > *pStream, long pColorComponents, EPdfColorSpace pAlternateColorSpace)
Hi, from a quick read of the proposed change: while the comments say 'lColorComponents', the code says 'pColorComponents', but more importantly, why to use 'long', which you cast to pdf_int64 afterwards, instead of using pdf_int64 directly? It would make more sense and can avoid some typing issues eventually. Bye, zyx ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users