On Tue, 2018-02-27 at 16:47 +0100, Francesco Pretto wrote: > On 27 February 2018 at 16:30, zyx <z...@gmx.us> wrote: > > while the comments say 'lColorComponents', the code says > > 'pColorComponents', but more importantly, why to use 'long', which > > you > > cast to pdf_int64 afterwards, instead of using pdf_int64 directly? > > Not relevant to the feature currently being talked, but > inconsistencies like this are already present in other very critical > parts of the library. See "void PdfVariant::SetNumber( long l ) and > "pdf_int64 PdfVariant::GetNumber()". These should be fixed at the > cost of breaking the ABI.
Hi, yes, I agree, consistency is important. And avoid long/pdf_long in the new code is another good goal to achieve. Bye, zyx ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users