Hello zyx, hello all, > On 01 March 2018 at 09:03 zyx <z...@gmx.us> wrote: > > > On Wed, 2018-02-28 at 22:54 +0100, Matthew Brincke wrote: > > I hope I hadn't promised to review more than one patch > > Hi, > well, I understood (and hoped) your statement as more than one will be > done, but if it was not meant like that, then my fault. I'm sorry.
I didn't know if I would manage to review more than one patch, so my promise was intentionally worded such that the number of patches I'd review was left open (so it could also mean just 1). For review of further patches I'd have needed (and still do) you/Dom to answer this question: How should I review patches which add public API? If the patch is otherwise good, should I commit the API addition (after adding some doxygen documentation if not already provided), before sending a review email to the list with the revision web URL? > Bye, > zyx > > P.S.: by the way, I'm on the list, I reply to message on the list, no > need to "reply to all" in case of replies to my messages, better to use > "reply to list". I know there are different opinions regarding "reply > to all" and "reply to list", but in my case it's like this. Just a > note, nothing serious :) > When the list mail processing (mostly/for me) worked, I did that (remove your/mostly everyone's) address from the mail's "To" field before sending), only when the list proved unreliable, I left it in to make (more) sure you would receive the email. I very much hope the sourceforge.net project mailing lists and their archive web pages (hopefully with the thread view fixed to show all emails, not missing some as it had been) return to proper service very soon. Best regards, mabri ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users