Hello,
First of all, thank you guys for the library, it's quite sharp and
nicely written. Although, there are some bugs we've found while using
the lib and we have patches applied on our side, so the question is: how
do we submit the patches for review, so they're included in the future
releases?
I've attached a sample path, the most recent one. We've discovered that
while PdfDocument::FillXObjectFromPage method combines input page
"Contents" array into the output stream, it doesn't add any separator
between array elements. On our test PDF that resulted a series of q...Q
operators merging into something like "q...Qq...Qq...Q" in the output
stream. Obviously "Qq" is not a valid operator and output document is
considered ill-formated. The fix is very simple one: we've added
pObjStream->Append(" ") between stream portions and it fixed the issue.
I have a bunch of such diff files covering, mostly covering minor
issues. Where should I send those and what's the review process?
And by the way, do you guys have some official Github repo maybe? It's
quite handy to work through forks, pull requests and issues tracker there.
Kind Regards,
Yaro Glushchenko
diff --git a/podofo/podofo/0.8/original/src/doc/PdfDocument.cpp
b/podofo/podofo/0.8/original/src/doc/PdfDocument.cpp
index 27550198..261e8000 100644
--- a/podofo/podofo/0.8/original/src/doc/PdfDocument.cpp
+++ b/podofo/podofo/0.8/original/src/doc/PdfDocument.cpp
@@ -539,6 +539,7 @@ PdfRect PdfDocument::FillXObjectFromPage( PdfXObject *
pXObj, const PdfPage * pP
pcontStream->GetFilteredCopy( &pcontStreamBuffer,
&pcontStreamLength );
pObjStream->Append( pcontStreamBuffer,
pcontStreamLength );
+ pObjStream->Append(" ");
podofo_free( pcontStreamBuffer );
break;
}
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
